Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/26668/notifications for shared calendars 2 #39702

Closed

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Aug 3, 2023

Summary

Fun fact: The default implementation for Sabre\CalDAV\Calendar.getOwner1 would always return the principaluri as owner. It's our overwrite in OCA\DAV\CalDAV\Calendar.getOwner2 causing the issues.

Issues

  1. Calendar shared editable from Alice to Bob. Bob adds an event and invites Alice. An iTip message is generated for Alice and will update the event in the shared calendar. If Alice adds an event and invites Bob, an additional event in Bob's personal calendar is created. The event in Bob's personal calendar is only created if Bob is already an attendee in the initial ics file, then the event in Bob's calendar is created before the event in Alice's calendar.

TODO

Checklist

Footnotes

  1. https://github.com/sabre-io/dav/blob/85b33f7c4b597bdb2a90e6886a48c5723e767062/lib/CalDAV/Calendar.php#L229-L240

  2. https://github.com/nextcloud/server/blob/780ece032fd42ec099d888a46a5349d8dea48dc2/apps/dav/lib/CalDAV/Calendar.php#L228-L232

@kesselb kesselb self-assigned this Aug 3, 2023
@kesselb kesselb force-pushed the feat/26668/notifications-for-shared-calendars-2 branch from 01dd5de to ca932b2 Compare August 8, 2023 19:16
@ChristophWurst ChristophWurst added the 1. to develop Accepted and waiting to be taken care of label Oct 17, 2023
@blizzz blizzz added this to the Nextcloud 29 milestone Nov 23, 2023
@blizzz
Copy link
Member

blizzz commented Nov 23, 2023

Please don't forget to set the milestone when opening a PR 😃

This is basically the original commit, but with the addition that
shared calendars in to account and adjusts their uri s.t. the Sabre
library can find the returned object uri in the user's calendar
collection.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
Try to fix some psalm things. No change to the code apart from that.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>

getCalendarObjectByUID(): prefer objects in shared writable calendars over private objects.

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>

fix: include the principalUri for dav_shares clause

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

feat: use getPrincipalURI only for shared calendars

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the feat/26668/notifications-for-shared-calendars-2 branch from b00d01e to 8e928ca Compare April 24, 2024 16:01
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 31 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send invitations for shared calendars
5 participants